Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabo/fix version #1978

Closed
wants to merge 1 commit into from
Closed

Fabo/fix version #1978

wants to merge 1 commit into from

Conversation

faboweb
Copy link
Contributor

@faboweb faboweb commented Aug 10, 2018

The version returned by gaiacli version is 0.22.0 which is not our correct version.

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Updated all relevant documentation (docs/)
  • Updated all relevant code comments
  • Wrote tests
  • Added entries in PENDING.md that include links to the relevant issue or PR that most accurately describes the change.
  • Updated cmd/gaia and examples/

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@zmanian
Copy link
Member

zmanian commented Aug 10, 2018

Don't merge this. Merge #1830 instead.

Copy link
Contributor

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good idea. Fixing this merge conflict when merging master back to develop won't be a big deal

@codecov
Copy link

codecov bot commented Aug 10, 2018

Codecov Report

Merging #1978 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1978   +/-   ##
========================================
  Coverage    64.86%   64.86%           
========================================
  Files          114      114           
  Lines         6837     6837           
========================================
  Hits          4435     4435           
  Misses        2120     2120           
  Partials       282      282

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #1830 (which should have happened right after 0.23.1 was released, but didn't), this isn't our intended flow.

@cwgoes cwgoes closed this Aug 10, 2018
@cwgoes cwgoes deleted the fabo/fix-version branch August 10, 2018 16:09
chillyvee pushed a commit to chillyvee/cosmos-sdk that referenced this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants