Rename stake Validator.Owner -> .Operator #1950
Conversation
alessio
requested review from
cwgoes,
ebuchman,
rigelrozanski and
zramsay
as code owners
|
what's with waiting for this linter to pass? maybe we should merge to a cosmos branch then merge in to develop from there? |
Why's that? |
|
because we've been waiting for the CI linter to run for a long long time |
|
Waiting until after v0.24 |
|
I'm very confused as to why setup_dependencies hasn't ended. It looks as though that job never got started? (Theres no |
| @@ -28,74 +28,74 @@ A validator is created using the `TxCreateValidator` transaction. | |||
|
|
|||
| ```golang | |||
| type TxCreateValidator struct { | |||
| OwnerAddr sdk.Address | |||
| Operator sdk.Address | |||
There was a problem hiding this comment.
Strings are same length:
alessio@bizet:~$ [ `echo "OwnerAddr sdk.Address" | wc -m` = `echo "Operator sdk.Address" | wc -m` ] && echo OK || echo KO
OK
Perhaps I misunderstood though.
x/stake/types/validator.go
Outdated
| var storeValue validatorValue | ||
| err = cdc.UnmarshalBinary(value, &storeValue) | ||
| if err != nil { | ||
| return | ||
| } | ||
|
|
||
| if len(ownerAddr) != 20 { | ||
| if len(operatorAddr) != 20 { |
There was a problem hiding this comment.
I believe @melekes is suggesting this should be a constant -- correct me if I'm wrong ;-)
There was a problem hiding this comment.
Yes, I think he is. @melekes could you elaborate please?
There was a problem hiding this comment.
What @alexanderbez said ^^
There was a problem hiding this comment.
Being addressed in #1997
|
ugh failing because of non-determinism - @alessio want to re-run test_cover? |
|
Hmmm, strange... |
|
Yeah I've seen this one a bunch is it not the same as the other nondeterministic test failure? |
|
That is the normal non-deterministic test failure on test_cover. Is there an open issue for it yet? |
|
@ValarDragon just made one (it didn't exist as far as I could tell) - also introduced a non-determinism issue label |
|
Strange -- no, I don't think so @ValarDragon |
|
Rebased on develop. |
|
@cosmos/cosmos-ui breaking |
alexanderbez
added
T: API Breaking
|
@faboweb I'm trying to add the |
--address-validatorrenamed to--validatorValidatorinterface'sGetOwner()renamed toGetOperator()Validator.Ownerrenamed toValidator.OperatorRelevant issue: #1901