Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(x/gov)!: backport of PR #18146: min amount per deposit #19312

Conversation

MSalopek
Copy link
Contributor

@MSalopek MSalopek commented Jan 31, 2024

Description

Backport: #18146

Minor changes were introduced where the interfaces don't match.
Minor changes in testing (gas calculations in operations_test.go)


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@MSalopek MSalopek requested a review from a team as a code owner January 31, 2024 15:28
@MSalopek MSalopek changed the title fix(x/gov)!: backport 18146: min amount per deposit fix(x/gov)!: backport of PR #18146: min amount per deposit Jan 31, 2024
@MSalopek
Copy link
Contributor Author

MSalopek commented Jan 31, 2024

Looking at tests

EDIT:
Backported and adapted where necessary

Copy link

@mpoke mpoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work @MSalopek.

@MSalopek MSalopek force-pushed the masa/backport-18146-min-amount-per-deposit branch from 76768d5 to 97faf4f Compare February 1, 2024 10:44
@mpoke mpoke merged commit eefb343 into cosmos:feature/v0.47.x-ics-lsm Feb 1, 2024
24 of 27 checks passed
czarcas7ic added a commit to osmosis-labs/cosmos-sdk that referenced this pull request Mar 22, 2024
…#19312) (#510)

* feat(x/gov): implement a minimum amount per deposit (cosmos#18146)

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* Fix

* Fix test

* Fix e2e

* Fix e2e

* Fix test

* update changelog

* Include expedited proposal logic

* Update deposit.go

---------

Co-authored-by: MSalopek <matija.salopek994@gmail.com>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: Adam Tucker <adam@osmosis.team>
Co-authored-by: Adam Tucker <adamleetucker@outlook.com>
czarcas7ic added a commit to osmosis-labs/cosmos-sdk that referenced this pull request Mar 25, 2024
czarcas7ic added a commit to osmosis-labs/cosmos-sdk that referenced this pull request Mar 25, 2024
czarcas7ic added a commit to osmosis-labs/cosmos-sdk that referenced this pull request Mar 25, 2024
tbruyelle pushed a commit to atomone-hub/atomone that referenced this pull request Sep 17, 2024
Backport of cosmos/cosmos-sdk#19312

Co-authored-by: Adam Hanna <ahanna@mines.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants