Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Context.BlockHeight #4578

Closed
1 of 4 tasks
alexanderbez opened this issue Jun 18, 2019 · 3 comments · Fixed by #4580
Closed
1 of 4 tasks

Remove Context.BlockHeight #4578

alexanderbez opened this issue Jun 18, 2019 · 3 comments · Fixed by #4580
Labels
good first issue T: Dev UX UX for SDK developers (i.e. how to call our code) Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.

Comments

@alexanderbez
Copy link
Contributor

alexanderbez commented Jun 18, 2019

Summary

The SDK's Context type provides the ability to set/get the following:

  • Block Header
  • Block Time
  • Block Height
  • Block proposer

All of these (excluding the header) are part of the header itself.

Problem Definition

When setting the block height, proposer or time, the header is updated accordingly but not the inverse! This can lead to bugs and a poor developer UX.

Proposal

Keep the functionality of allowing the developer to set (With*) block fields, but only allow getting the header. i.e. remove BlockHeight


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alexanderbez alexanderbez added good first issue Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. T: Dev UX UX for SDK developers (i.e. how to call our code) labels Jun 18, 2019
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 200.0 DAI (200.0 USD @ $1.0/DAI) attached to it.

alessio pushed a commit that referenced this issue Jun 18, 2019
@gitcoinbot
Copy link

gitcoinbot commented Jun 18, 2019

Issue Status: 1. Open 2. Cancelled


Workers have applied to start work.

These users each claimed they can complete the work by 1 year, 8 months ago.
Please review their action plans below:

1) vic-en has applied to start work (Funders only: approve worker | reject worker).

I've gone through the project issue and code on github. I am assuring you I can get this done soon as I am also an expert at goland with lots of experience with blockchain technology. I await your approval to convince you and get this issue fixed soon. Thanks.
2) joshikeno has applied to start work (Funders only: approve worker | reject worker).

Hello, went through the repo and saw the merger #4580. I would like to ask if this issue is open?

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Cancelled


The funding of 200.0 DAI (200.0 USD @ $1.0/DAI) attached to this issue has been cancelled by the bounty submitter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue T: Dev UX UX for SDK developers (i.e. how to call our code) Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants