Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Make cli tests use build files #3808

Merged
merged 2 commits into from
Mar 7, 2019
Merged

Conversation

jaekwon
Copy link
Contributor

@jaekwon jaekwon commented Mar 5, 2019

No description provided.

@@ -160,8 +160,8 @@ godocs:

test: test_unit

test_cli:
@go test -p 4 `go list github.com/cosmos/cosmos-sdk/cmd/gaia/cli_test` -tags=cli_test
test_cli: build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@@ -163,7 +163,7 @@ func (f *Fixtures) Flags() string {

// UnsafeResetAll is gaiad unsafe-reset-all
func (f *Fixtures) UnsafeResetAll(flags ...string) {
cmd := fmt.Sprintf("gaiad --home=%s unsafe-reset-all", f.GDHome)
cmd := fmt.Sprintf("../../../build/gaiad --home=%s unsafe-reset-all", f.GDHome)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this is something we should define on the Fixtures object (maybe gdcmd and gclicmd attributes) then it can be easily switched in and out for different usages (one example would be checking in NewFixtures if CI=true and directing to a previously built binary).

@jackzampolin
Copy link
Member

jackzampolin commented Mar 5, 2019

This localnet failure is due to not being able to pull the tendermint/gaianode image:

Unable to find image 'tendermint/gaiadnode:latest' locally
docker: Error response from daemon: pull access denied for tendermint/gaiadnode, repository does not exist or may require 'docker login'.
See 'docker run --help'.
make: *** [localnet-start] Error 125
Exited with code 2

It sounds like this issue has been fixed. Kicking the tests. Great add @jaekwon!

PENDING.md Outdated Show resolved Hide resolved
Add PR number.
@codecov
Copy link

codecov bot commented Mar 7, 2019

Codecov Report

Merging #3808 into develop will increase coverage by 0.07%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #3808      +/-   ##
===========================================
+ Coverage    60.88%   60.95%   +0.07%     
===========================================
  Files          191      191              
  Lines        14180    14185       +5     
===========================================
+ Hits          8633     8647      +14     
+ Misses        4991     4984       -7     
+ Partials       556      554       -2

@jackzampolin jackzampolin merged commit a24dee0 into develop Mar 7, 2019
@jackzampolin jackzampolin deleted the jae/cli_tests_use_build branch March 7, 2019 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants