Skip to content

Commit

Permalink
Merge PR #3808: Make cli tests use build files
Browse files Browse the repository at this point in the history
* Make cli tests use build files

* Update PENDING.md

Add PR number.
  • Loading branch information
jaekwon authored and jackzampolin committed Mar 7, 2019
1 parent 4816dbe commit a24dee0
Show file tree
Hide file tree
Showing 4 changed files with 49 additions and 47 deletions.
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,8 @@ godocs:

test: test_unit

test_cli:
@go test -p 4 `go list github.com/cosmos/cosmos-sdk/cmd/gaia/cli_test` -tags=cli_test
test_cli: build
@go test -p 4 `go list ./cmd/gaia/cli_test/...` -tags=cli_test

test_ledger:
# First test with mock
Expand Down
2 changes: 2 additions & 0 deletions PENDING.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@

### Gaia

* #3808 `gaiad` and `gaiacli` integration tests use ./build/ binaries.

### SDK

### Tendermint
Expand Down
2 changes: 1 addition & 1 deletion client/lcd/test_helpers.go
Original file line number Diff line number Diff line change
Expand Up @@ -668,7 +668,7 @@ func doTransfer(
resp, body, recvAddr := doTransferWithGas(
t, port, seed, name, memo, pwd, addr, "", 1.0, false, true, fees,
)
require.Equal(t, http.StatusOK, resp.StatusCode, resp)
require.Equal(t, http.StatusOK, resp.StatusCode, body)

var txResp sdk.TxResponse
err := cdc.UnmarshalJSON([]byte(body), &txResp)
Expand Down
Loading

0 comments on commit a24dee0

Please sign in to comment.