Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gaiacli tx send/sign doesn't respect the -o flag #3249

Closed
4 tasks
jackzampolin opened this issue Jan 8, 2019 · 2 comments
Closed
4 tasks

Gaiacli tx send/sign doesn't respect the -o flag #3249

jackzampolin opened this issue Jan 8, 2019 · 2 comments

Comments

@jackzampolin
Copy link
Member

Summary of Bug

gaiacli tx send has a separate --json flag to output a JSON response. In the rest of the SDK we use the --output flag to induce this behavior. We should switch to using that flag in the tx send command.

Steps to Reproduce


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@jackzampolin jackzampolin self-assigned this Jan 8, 2019
@jackzampolin jackzampolin changed the title Gaiacli tx send doesn't respect the -o flag Gaiacli tx send/sign doesn't respect the -o flag Jan 8, 2019
@alessio
Copy link
Contributor

alessio commented Jan 23, 2019

I suspect this is not a launch blocker - @jackzampolin can we update labels accordingly then?

@jackzampolin
Copy link
Member Author

@alessio this would not block launch, but a through review of the CLI and updating of commands to respect standard flags is something I would really like to see prelaunch

alessio pushed a commit that referenced this issue Jan 23, 2019
gaiad tendermint show-{address,validator} now take --machine-parseable/-m
for machine parseable output.

Closes: #3249
cwgoes pushed a commit that referenced this issue Jan 24, 2019
* remove --json flag from all commands and CLIContext

gaiad tendermint show-{address,validator} now take --machine-parseable/-m
for machine parseable output.

Closes: #3249

* Revert machine-parseable thing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants