Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test that store impls do not allow nil values #2707

Closed
jaekwon opened this issue Nov 7, 2018 · 0 comments
Closed

Test that store impls do not allow nil values #2707

jaekwon opened this issue Nov 7, 2018 · 0 comments
Assignees
@mossid @cwgoes
Labels
C:Store T: Tests
Milestone
v0.31.0 (Launch RC)

Comments

@jaekwon
Copy link
Contributor

jaekwon commented Nov 7, 2018

KVStore, CacheKVStore, etc should not allow nil values to be stored.
It's sometimes used accidentally to delete a value, but .Delete() should be used instead.

The issue is that we should write tests for all of our store impls to enforce this.
@jaekwon jaekwon mentioned this issue Nov 7, 2018
Merged
@cwgoes cwgoes mentioned this issue Jan 16, 2019
Closed
@jackzampolin jackzampolin added this to the v0.30.0 (Launch RC) milestone Jan 29, 2019
@cwgoes cwgoes mentioned this issue Jan 29, 2019
Merged
5 tasks
chillyvee pushed a commit to chillyvee/cosmos-sdk that referenced this issue Mar 1, 2024
@yaruwangway
chore: update to v13 (cosmos#2707)
ae64d50 
* update to v13

* update upgrade script

* update test upgrade script

* update sed command

* update app.go

* update upgradeFrom version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mossid mossid

@cwgoes cwgoes

Labels
C:Store T: Tests
Projects
None yet
Milestone
v0.31.0 (Launch RC)
Development

No branches or pull requests
5 participants
@jaekwon @jackzampolin @mossid @cwgoes @fedekunze