Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement gaiacli sign for manual signing of transactions #1953

Closed
jackzampolin opened this issue Aug 10, 2018 · 1 comment
Closed

Implement gaiacli sign for manual signing of transactions #1953

jackzampolin opened this issue Aug 10, 2018 · 1 comment
Assignees
@alessio
Labels
C:CLI T: Security

Comments

@jackzampolin
Copy link
Member

jackzampolin commented Aug 10, 2018 •
edited by alessio
Loading

ref #966

This issue is part of implementing the generate, sign, send workflow for offline transaction generation. It should also be a place to discuss implementation details for gaiacli sign

Description

As a gaiacli user
I want to sign a Tx that was generated beforehand
So that I can review the contents of the transaction before broadcasting it.

Acceptance Criteria AC1

Given a transaction file generated with gaiacli --generate-only and an account name
When I run gaiacli sign
Then a signature is generated with the given account's key and
it is attached to the transaction and
its JSON representation is printed out.

Acceptance Criteria AC2

Given a transaction file generated with gaiacli --generate-only and a HD key
When I run gaiacli sign
Then a signature is generated with the given key and
it is attached to the transaction and
its JSON representation is printed out.
@alessio

This comment has been minimized.

Sign in to view
alessio added a commit that referenced this issue Aug 28, 2018
@alessio
Draft sign command implementation
4194c7c 
See #1953
@alessio alessio mentioned this issue Aug 31, 2018
Closed
7 tasks
@alessio alessio mentioned this issue Sep 3, 2018
Merged
5 tasks
alessio pushed a commit that referenced this issue Sep 5, 2018
Implement command/REST endpoint for offline tx sign off #1953
0ada320 
* Add sign CLI command to sign transactions generated with the
  --generate-only flag.
* Add /sign REST endpoint for Voyager support.

Redirect password prompt to STDERR to avoid messing up cli
commands output. As a rule of thumb, program's output should
always go to STDOUT, whilst errors&diagnostics go to STDERR
as per POSIX's philosophy and specs.
alessio pushed a commit that referenced this issue Sep 5, 2018
Implement command/REST endpoint for offline tx sign off #1953
052bb1f 
* Add sign CLI command to sign transactions generated with the
  --generate-only flag.
* Add /sign REST endpoint for Voyager support.

Redirect password prompt to STDERR to avoid messing up cli
commands output. As a rule of thumb, program's output should
always go to STDOUT, whilst errors&diagnostics go to STDERR
as per POSIX's philosophy and specs.
alessio pushed a commit that referenced this issue Sep 6, 2018
Implement command/REST endpoint for offline tx sign off #1953
d776283 
* Add sign CLI command to sign transactions generated with the
  --generate-only flag.
* Add /sign REST endpoint for Voyager support.

Redirect password prompt to STDERR to avoid messing up cli
commands output. As a rule of thumb, program's output should
always go to STDOUT, whilst errors&diagnostics go to STDERR
as per POSIX's philosophy and specs.
alessio pushed a commit that referenced this issue Sep 6, 2018
Implement command/REST endpoint for offline tx sign off #1953
21b00a8 
* Add sign CLI command to sign transactions generated with the
  --generate-only flag.
* Add /sign REST endpoint for Voyager support.

Redirect password prompt to STDERR to avoid messing up cli
commands output. As a rule of thumb, program's output should
always go to STDOUT, whilst errors&diagnostics go to STDERR
as per POSIX's philosophy and specs.
alessio pushed a commit that referenced this issue Sep 7, 2018
Implement command/REST endpoint for offline tx sign off #1953
e6a8a4d 
* Add sign CLI command to sign transactions generated with the
  --generate-only flag.
* Add /sign REST endpoint for Voyager support.

Redirect password prompt to STDERR to avoid messing up cli
commands output. As a rule of thumb, program's output should
always go to STDOUT, whilst errors&diagnostics go to STDERR
as per POSIX's philosophy and specs.
cwgoes added a commit that referenced this issue Sep 7, 2018
@cwgoes
Merge PR #2216: Implement command/REST endpoint for offline signing #…
896d259 
…1953
chillyvee pushed a commit to chillyvee/cosmos-sdk that referenced this issue Mar 1, 2024
@okwme
exclude e2e tests from test coverage upload (cosmos#1953)
a76d309 
* exclude e2e tests from test coverage upload

* swap order of test to exclude e2e

* remove e2e from find
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alessio alessio

Labels
C:CLI T: Security
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alessio @jackzampolin