Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: TxBuilder does not allow to SetSignatures with an empty Public Key #19094

Closed
1 task done
cmwaters opened this issue Jan 17, 2024 · 2 comments · Fixed by #19106
Closed
1 task done

[Bug]: TxBuilder does not allow to SetSignatures with an empty Public Key #19094

cmwaters opened this issue Jan 17, 2024 · 2 comments · Fixed by #19106
Labels

Comments

@cmwaters
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

As far as I can understand from the code, it is not compulsory to include the public key in the AuthInfo of the transaction. It is predominantly needed for the first transaction used by an account and is afterwards saved to state so following transaction don't need it.

I would have expected to be able to run SetSignatures with the PubKey field left empty but I get the following error:

panic: error setting draft signatures: Expecting non nil value to create a new Any: failed packing protobuf message to Any [celestiaorg/cosmos-sdk@v1.20.0-sdk-v0.46.16/codec/types/any.go:61] [recovered]

Cosmos SDK Version

v0.46 and later

How to reproduce?

Have a test call SetSignatures with the PubKey field empty.

@cmwaters cmwaters added the T:Bug label Jan 17, 2024
@cmwaters
Copy link
Contributor Author

I'm working on a fix here celestiaorg#371 on my fork of the SDK that I'd be happy to upstream

@alexanderbez
Copy link
Contributor

@cmwaters the proposal makes sense to me and it seems erroring should not happen. Would be happy to review and accept a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants