Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove testify suite when necessary and reduce test duplication #14561

Closed
1 of 19 tasks
julienrbrt opened this issue Jan 9, 2023 · 1 comment
Closed
1 of 19 tasks

Remove testify suite when necessary and reduce test duplication #14561

julienrbrt opened this issue Jan 9, 2023 · 1 comment
Labels

Comments

@julienrbrt
Copy link
Member

julienrbrt commented Jan 9, 2023

Summary

We are in the process of improving further our tests (#14145).
The SDK is overly using testify suite, even when the suite only has one test (e.g. #14545).

Moreover, many tests have been duplicated during the creation of e2e tests. We should verify what tests are equivalent and keep only the necessary (this should lead to no coverage decrease)

Work Breakdown

  • Remove testify suite when it simplifies a test. The removal should happen package per package.
  • Verify test duplication. We have duplicated many tests when using mocks, integration and e2e. Per package, we should ensure we do not duplicate tests.
  • Verify the flakiness of the migrated packages with act or directly in CI.

Tasks

Basically, all packages in the Cosmos SDK that have e2e tests should be checked.

  • auth
  • authz
  • bank
  • client
  • crisis
  • distribution
  • evidence
  • feegrant
  • genutil
  • gov
  • group
  • mint
  • nft
  • params
  • server
  • slashing
  • staking
  • tx
  • upgrade
@julienrbrt
Copy link
Member Author

julienrbrt commented Oct 1, 2024

Supersede by #20800

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🥳 Done
Development

No branches or pull requests

2 participants