Improve DescribeMachine unit test by checking that something is returned

[pallotron]

This commit fixes a bug where machineProps was not returned.
I added some logic to the unit test:

$ sudo go test -v
=== RUN   TestMachine
    dbus_test.go:132: machine machined-test-register-gkkxchal properties: map[Class:container Id:[] Leader:435704 Name:machined-test-register-gkkxchal NetworkInterfaces:[] RootDirectory: Service:go-systemd State:running Timestamp:1728652846963827 TimestampMonotonic:6097688654967 Unit:machined-test-register-gkkxchal.service]
    dbus_test.go:132: machine machined-test-register-with-network-bfeyiref properties: map[Class:container Id:[] Leader:435706 Name:machined-test-register-with-network-bfeyiref NetworkInterfaces:[] RootDirectory: Service:go-systemd State:running Timestamp:1728652846964826 TimestampMonotonic:6097688655967 Unit:machined-test-register-with-network-bfeyiref.service]
    dbus_test.go:132: machine machined-test-create-thdkckgj properties: map[Class:container Id:[] Leader:435708 Name:machined-test-create-thdkckgj NetworkInterfaces:[] RootDirectory: Service:go-systemd State:running Timestamp:1728652846966834 TimestampMonotonic:6097688657975 Unit:machine-machined\x2dtest\x2dcreate\x2dthdkckgj.scope]
    dbus_test.go:132: machine machined-test-create-with-network-mkqmytyw properties: map[Class:container Id:[] Leader:435710 Name:machined-test-create-with-network-mkqmytyw NetworkInterfaces:[] RootDirectory: Service:go-systemd State:running Timestamp:1728652846972931 TimestampMonotonic:6097688664072 Unit:machine-machined\x2dtest\x2dcreate\x2dwith\x2dnetwork\x2dmkqmytyw.scope]
--- PASS: TestMachine (0.13s)
=== RUN   TestImages
--- PASS: TestImages (0.00s)
PASS
ok      github.com/coreos/go-systemd/v22/machine1       0.134s

[pallotron]

@cgwalters would you be so kind to merge this? :)

[prestist]

Hmm, I always thought this to be more of a stylistic difference rather then functional? did this really fix the bug?

[pallotron]

well... I think so? maybe the original intention was to pass machineProps by reference (maps are always passed by reference in go IIRC), I will check on Monday removing this and see if the unit test below still pass :)

[pallotron]

alright, nvm you are right.

# pallotron @ devvm3927 in ~/src/go-systemd/machine1 on git:main x [9:22:08]
$ git diff
diff --git a/machine1/dbus.go b/machine1/dbus.go
index 49207ea..79c30ea 100644
--- a/machine1/dbus.go
+++ b/machine1/dbus.go
@@ -163,7 +163,7 @@ func (c *Conn) DescribeMachine(name string) (machineProps map[string]interface{}
        for key, val := range dbusProps {
                machineProps[key] = val.Value()
        }
-       return machineProps, nil
+       return
 }

 // KillMachine sends a signal to a machine

# pallotron @ devvm3927 in ~/src/go-systemd/machine1 on git:main x [9:22:24]
$ sudo go test -v
=== RUN   TestMachine
    dbus_test.go:132: machine machined-test-register-tshpleci properties: map[Class:container Id:[] Leader:4058823 Name:machined-test-register-tshpleci NetworkInterfaces:[] RootDirectory: Service:go-systemd State:running Timestamp:1729268546548624 TimestampMonotonic:269560782174 Unit:machined-test-register-tshpleci.service]
    dbus_test.go:132: machine machined-test-register-with-network-segaprxj properties: map[Class:container Id:[] Leader:4058825 Name:machined-test-register-with-network-segaprxj NetworkInterfaces:[] RootDirectory: Service:go-systemd State:running Timestamp:1729268546549606 TimestampMonotonic:269560783156 Unit:machined-test-register-with-network-segaprxj.service]
    dbus_test.go:132: machine machined-test-create-gvuxnxby properties: map[Class:container Id:[] Leader:4058828 Name:machined-test-create-gvuxnxby NetworkInterfaces:[] RootDirectory: Service:go-systemd State:running Timestamp:1729268546551546 TimestampMonotonic:269560785096 Unit:machine-machined\x2dtest\x2dcreate\x2dgvuxnxby.scope]
    dbus_test.go:132: machine machined-test-create-with-network-uhlgksmc properties: map[Class:container Id:[] Leader:4058831 Name:machined-test-create-with-network-uhlgksmc NetworkInterfaces:[] RootDirectory: Service:go-systemd State:running Timestamp:1729268546556992 TimestampMonotonic:269560790542 Unit:machine-machined\x2dtest\x2dcreate\x2dwith\x2dnetwork\x2duhlgksmc.scope]
--- PASS: TestMachine (0.10s)
=== RUN   TestImages
--- PASS: TestImages (0.00s)
PASS
ok      github.com/coreos/go-systemd/v22/machine1       0.106s

I will amend this, because I still think it's handy to have the check below. does it work?

[pallotron]

done

[prestist]

Thank you for contributing, if you want to add the logging and additional checks to the test they make sense to me. Before I can approve this though we need to clean up the commit details a bit.
Squash the commits we have into one then lets name it something more appropriate.

Wdyt:
debus_test: add additional checks on machine properties