Removed requirement to have bower when installing with NPM #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #47 |
|
The issue here is that even when corejs-typeahead is just a dependency of your main project, it tries to install dependencies for testing using bower. This is unnecessary. |
|
@corejavascript/collaborators Any objections to me merging this? It seems like Bower is just redundantly requiring jquery as a dependency. Needing to run Bower is causing problems for us in CI and testing. Seems easiest just to eliminate the use of Bower and let NPM handle the dependencies (since jquery is already listed in package.json). |
jlbooker
approved these changes
Oct 24, 2016
|
👍 Thanks @mattiasrunge ! Fixes #47 |
This was referenced Oct 24, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing with NPM it tries to run "bower install" but if bower does not exist NPM will fail. I don't see why this is needed when installing via NPM.