Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make browser tests work again #21

Closed
wants to merge 5 commits into from
Closed

Make browser tests work again #21

wants to merge 5 commits into from

Conversation

jesperronn
Copy link
Contributor

Adding my Sauce Labs account with the hope to actually test in 11 browsers on Sauce Labs

I am uncertain if this is enough by itself, since the abandoned project had
credentials already (probably from @jharding)

Originally added to twitter/typeahead.js in July 2014
twitter/typeahead.js@f5af04b

In case you want to revisit this in 5 years, my saucelab user account is 'jesperronn'

When this PR works, it will fix #20

…wsers on Sauce Labs

In case you want to revisit this in 5 years, my saucelab user account is 'jesperronn'
@jesperronn
Copy link
Contributor Author

hmm, https://github.com/jesperronn/typeahead.js/commit/42aabc6d9a3c74773e8f7f1201b48f91e15da543 didn't work. The browser tests still don't run since "$TRAVIS_SECURE_ENV_VARS" still evaluates to false

Will put this PR in WIP until I'm satisfied. Feel free to help :)

@jesperronn jesperronn changed the title adding my sauce laps account with the hope to actually test in 11 browsers on Sauce Labs WIP Make browser tests work again Oct 16, 2015
@lenovouser
Copy link
Contributor

@jesperronn I think you might need to add

TRAVIS_SECURE_ENV_VARS = true

or

$TRAVIS_SECURE_ENV_VARS = true

to travis-ci.org:corejavascript/typeahead.js/settings.

@jesperronn
Copy link
Contributor Author

Hmm https://github.com/jesperronn/typeahead.js/commit/cddcbbe733ea2d8911873cece70c53662b2ae4e6 did not work either. From the Travis configuration I read that

Encrypted environment variables are not available to pull requests from forks due to the security
risk of exposing such information to unknown code.

Which means that this Pull request will never run the saucelabs tests.

@jesperronn jesperronn changed the title WIP Make browser tests work again Make browser tests work again Oct 16, 2015
@lenovouser lenovouser added this to the v0.11.2 milestone Oct 21, 2015
@jlbooker
Copy link
Contributor

@jesperronn & @Apfeluser Due to the Travis environment var limitation on pull requests noted above, I suggest we just merge this PR and see what happens. It won't break anything in terms of actual functionality.

@jesperronn
Copy link
Contributor Author

@jlbooker & @corejavascript/collaborators Even though this were merged, my preliminary findings show me that I cannot even run these locally... perhaps some package inconsistency. I would love to solve #26 so that we can actually verify the tests locally (just for Phantom or Chrome).

Preferably work on with this after a solution has been provided for #26

@jlbooker
Copy link
Contributor

@jesperronn Thanks for the update! (Sorry for the late reply, didn't see the GH notification!)

Moving this to the next milestone so we can get this release out the door. Let's continue working on this.

@jlbooker jlbooker modified the milestones: v1.1.0, v1.0.0 Nov 10, 2016
@jlbooker jlbooker modified the milestones: v1.1.0, v1.2.0 Dec 21, 2016
@jcrben
Copy link
Contributor

jcrben commented Jul 21, 2017

We should really revive this before merging too many merge requests...

@jesperronn
Copy link
Contributor Author

Closing this as it has been open for ages. Feel free to reopen if you feel this is still relevant.

@jesperronn jesperronn closed this Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Travis Not running Browser tests
4 participants