Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop propagation when selecting an entry #13

Merged

Conversation

Intrepidd
Copy link

See twitter/typeahead.js#1095

Selecting an entry doesn't stop the propagation, and causes a nasty effect when there are handlers on the keypress on a textarea, such as submitting the form.

This PR stops the propagation when pressing enter, as a default.

If you're not happy with it being a default, do you consider making it an option?

Thanks

@lenovouser
Copy link
Contributor

Hm. I think making this default is okay, as it doesn't seem to break anything.

/cc @corejavascript/collaborators

@jcrben
Copy link
Contributor

jcrben commented Oct 20, 2015

Couldn't this end up being a breaking change if the user depended on the event propogation? Seems unlikely but still possible.

I think this should project should ultimately use semantic versioning, but we could probably hold off on that until the first release is complete. We should probably summarize the changes in the release notes and note which ones could break backwards-compatibility.

So 👍 I guess.

@core-system-dev core-system-dev added this to the v0.11.2 milestone Oct 21, 2015
@core-system-dev
Copy link
Contributor

I second @jcrben

@Apfeluser do you mind adding a commit with this change to the release notes for v0.11.2 when this gets merged?

@jarthod
Copy link

jarthod commented Oct 23, 2015

Indeed it is worth telling the user in the changelog so he can find the reason easily if he was depending on this. Otherwise this is definitely a better default behavior. 👍

@lenovouser
Copy link
Contributor

@CoreSystemDevelopment 3d929c8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants