Add jQuery 3 compatibility #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcrben
approved these changes
Jul 21, 2017
There was a problem hiding this comment.
Seems reasonable - I no longer use jQuery much but glanced at https://stackoverflow.com/questions/6169826/propchecked-false-or-removeattrchecked.
Approved but merge conflicts need to be resolved.
`removeAttr` cannot be used with boolean attributes (`required`).
Instead, use `prop('required', false)`.
|
@jcrben Rebased and conflicts resolved. Thanks for reviewing! |
|
Are you interested in becoming a maintainer? I no longer use this library. |
|
I don't use this library much any more either but I'm happy to help out from time to time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removeAttrcannot be used with boolean attributes (required).Instead, use
prop('required', false).