Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration from Catch2 v2 to v3? #26

Open
XzoRit opened this issue Jan 6, 2024 · 2 comments
Open

Migration from Catch2 v2 to v3? #26

XzoRit opened this issue Jan 6, 2024 · 2 comments

Comments

@XzoRit
Copy link

XzoRit commented Jan 6, 2024

Hi and thanks for this really interesting library.

While playing around with it locally the tests would not build because I was using Catch2 v3.
I was able to make it compile, link and run the tests successfully with just a few little changes:
How to migrate projects from v2 to v3

If you are interested I would be happy to create a pull request for supporting Catch2 v3.

@agserm
Copy link
Member

agserm commented Jan 8, 2024

Thanks for reporting this, and I'm glad you found the library interesting.

We want to stay with Catch2 v2 since it is header only. We think the best way to resolve the issue you brought up is to embed the Catch2 header with cs_libguarded as we have done in several of our other libraries. These are minor changes and they should be pushed shortly.

@XzoRit
Copy link
Author

XzoRit commented Jan 9, 2024

Great.
Sounds like a plan 😄 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants