Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BostonInRoutingFareCalculator and BogotaInRoutingFareCalculator don't apply locale-specific dominance logic #595

Open
mattwigway opened this issue Apr 13, 2020 · 0 comments

Comments

@mattwigway
Copy link
Contributor

Both the Boston and Bogotá InRoutingFareCalculators call transferAllowance.tightenExpiration, which returns a regular transfer allowance, not a Boston/Bogotá transfer allowance, meaning that any Boston or Bogotá-specific logic implemented in atLeastAsGoodForAllFutureRedemptions is not actually executed.

mattwigway added a commit to mattwigway/r5 that referenced this issue Apr 13, 2020
mattwigway added a commit to mattwigway/r5 that referenced this issue Apr 13, 2020
mattwigway added a commit to mattwigway/r5 that referenced this issue May 11, 2020
mattwigway added a commit to mattwigway/r5 that referenced this issue Nov 13, 2020
mattwigway added a commit to mattwigway/r5 that referenced this issue Nov 13, 2020
mattwigway added a commit to mattwigway/r5 that referenced this issue Nov 24, 2020
mattwigway added a commit to mattwigway/r5 that referenced this issue Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant