-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Font Antialiasing Issues #926
Comments
Did you try changing AA in contour config? That's why it's there, if no option works for you, this is then a bug |
I didn't touch font code nor OpenGL rendering code in a long time. That most likely could not have changed. Is this a new problem to you? I very rarely experience a weirdly rendered character. I remember I fixed that by slightly increasing the font size. I'm using gray-scale AA. 🤔 hmmm.... is this problem specific to one glyph and/or one font? |
It's basically totally new. I compiled today and had this problem. It is also not only one specific glyph. It's happening depending on background color and or it seems depending also on font resolution which i usually change with hotkeys inside of contour. |
Meet same issue but with only on one computer which I get coutour from source code on master. But I can't see this issue with my another computer that I get contour from github Release. I can test on first computer with Release contour tomorrow. Edit: |
Didn't give anything out of the ordenary. Besides alot of messages like -> Also updating the config doesn't helped -> https://termbin.com/9h52 | same issues PS: The colorscheme is adapted from gruvbox-material -> i didn't used the new features like statusline and so on so i never adapted for the new modes but maybe someone want's to ... |
i wanted to try the release build but both release branch and master fail for me to build now -> https://termbin.com/obxn |
Just download from here https://github.com/contour-terminal/contour/releases/tag/v0.3.8.247 |
Indeed, this one |
It seems that this commit broke rendering |
i can confirm a7bb938 broke it , thank you for the help |
Great, thanks @Utkarsh-khambra can you look at why is it happening ? |
I think I can spare you the pain of debugging through the OpenGL code, which isn't actually too hard, but in order to understand it, one should probably also know how OpenGL works internally and all related side effects. :-) I think the problem is that the width is being changed, for the OpenGL rendering, but the actual width on the display will not change (and cannot). so the width must not be changed - as the painted scene must be put down to OpenGL pixel-perfect. Why? Because otherwise OpenGL tries to be intelligent and interpolates the textures such that it fits the desired target dimensions, resulting into artifacts (like above). I think, an attempted fix therefore would be to at least revert the part where the width is being changed, and then look for another solution. 🤔 hmm... |
Reading through the motivation text of the PR again:
I think one way to solve that would be to touch QOpenGLWidget::sizeHint() instead. I am not a Qt pro (sadly!), and there's still the QML PR open that btw addresses the scrollbar issue entirely differently (i.e. the problem doesn't even apply). but I think it'll take me quite a bit more until I can merge the QML PR, sorry :) |
I checked all the text rendering stuff with the default config, where the scrollbar is visible by default, that's why I didn't notice this. I'll look into this. |
I will close this issue, if you still encounter it @Glog78 just reopen it then |
Contour Terminal version
0.3.9-master-f05bb1a5
Installer source
Github: source code cloned
Operating System
arch linux
Architecture
x86-64
Other Software
none
Steps to reproduce
compiled from source qt5 Increasing Fontsize might make it more obvious used gray as antialiasing setting. Happens after my latest rebuild from git (today)
Config -> https://termbin.com/34pr6
Expected Behavior
Glyphs to be rendered smooth
Actual Behavior
see -> t , corners of the c , o in mastodon , shadow after n in online
Additional notes
No response
The text was updated successfully, but these errors were encountered: