Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IME preedit text field colors are currently hard coded (make them part of the color scheme) #1058

Closed
christianparpart opened this issue Mar 6, 2023 · 0 comments · Fixed by #1072
Labels
enhancement New feature or request feature-request User requested features good first issue Good for newcomers VT: Backend Virtual Terminal Backend (libterminal API)
Milestone

Comments

@christianparpart
Copy link
Member

they should be read from the color scheme, defaulting to the colors (and style state) that we're having right now.

Not sure it's a good thing, but whether or not to use bold text for rendering it, should probably be made configurable as well. But this is up for consideration only.

auto textAttributes = GraphicsAttributes {};
textAttributes.foregroundColor = RGBColor(0xFF, 0xFF, 0xFF);
textAttributes.backgroundColor = RGBColor(0xFF, 0x00, 0x00);
textAttributes.flags |= CellFlags::Bold | CellFlags::Underline;

@christianparpart christianparpart added enhancement New feature or request feature-request User requested features VT: Backend Virtual Terminal Backend (libterminal API) labels Mar 6, 2023
@christianparpart christianparpart added this to the 2023-1 milestone Mar 6, 2023
@christianparpart christianparpart added the good first issue Good for newcomers label Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature-request User requested features good first issue Good for newcomers VT: Backend Virtual Terminal Backend (libterminal API)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant