Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClientStatic.ts does not pass noImplicitAny checks with TSC. Simple fix. #17

Closed
opgbaudouin opened this issue Mar 6, 2021 · 2 comments

Comments

@opgbaudouin
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch contensis-management-api@1.0.2-beta.2 for the project I'm working on.

when using the code in a pure typescript environment using TSC (typescript 4.2.3) using the 'strict:true' is TJSON there is 1 file that has an 'implicitAny return'. All it needed to pass is add :any . (or naturally if it does return something to add that).

Here is the diff that solved my problem:

diff --git a/node_modules/contensis-management-api/src/models/ClientStatic.ts b/node_modules/contensis-management-api/src/models/ClientStatic.ts
index da771f3..62581f9 100644
--- a/node_modules/contensis-management-api/src/models/ClientStatic.ts
+++ b/node_modules/contensis-management-api/src/models/ClientStatic.ts
@@ -3,5 +3,5 @@ import { Config } from './Config';
 export interface ClientStatic {
 	defaultClientConfig: Config;
 	create(config?: Config): ContensisClient;
-	configure(config: Config);
+	configure(config: Config): any;
 }

This issue body was partially generated by patch-package.

@alexpop-zengenti
Copy link
Member

alexpop-zengenti commented Jan 28, 2022

Hi Onno,
We use TypeScript 3 now, but we plan to upgrade to TypeScript 4 and we will address this issue together with similar problems during the upgrade.

@alexpop-zengenti
Copy link
Member

Hi Onno, this issue should be solved in our 2.1.0 release.
Cheers,
Alex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants