fork: use 8MB stack if rlimit returns unlimited #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utam0k
reviewed
Aug 21, 2021
| let default_stack_size = if rlimit.rlim_cur != u64::MAX { | ||
| rlimit.rlim_cur as usize | ||
| } else { | ||
| DEFAULT_STACK_SIZE |
There was a problem hiding this comment.
Could you have it output using log::info! with a reason to use the default stack size?
utam0k
reviewed
Aug 21, 2021
There was a problem hiding this comment.
@MoZhonghua
Thanks for your first contribution. I commented on this PR. Could you look at it?
MoZhonghua
force-pushed
the
fix-mmap-ENOMEM
branch
from
a719212
to
90a6ad3
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #213