-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vulkan image and show size #353
base: main
Are you sure you want to change the base?
Conversation
This is a replacement for #270 |
|
||
RUN git clone https://github.com/ggerganov/llama.cpp && \ | ||
cd llama.cpp && \ | ||
git reset --hard ${LLAMA_CPP_SHA} && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rhatdan do you know if ARGS like LLAMA_CPP_SHA and WHISPER_CPP_SHA get inherited from parent container images?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming they don't, but I don't know
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only if they are set as Environment variables, which currently they are not. If we want this to be set we could do it via environment in ramalama Containerfile
env LLAMA_CPP_SHA=${LLAMA_CPP_SHA}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying it out now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works: #355
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool that's better, I'll merge yours
Add this image, we also want to see the size of this image in the build. Co-authored-by: Steffen Roecker <sroecker@redhat.com> Signed-off-by: Eric Curtin <ecurtin@redhat.com>
@@ -2,6 +2,9 @@ FROM quay.io/ramalama/ramalama:latest | |||
|
|||
RUN /usr/bin/python3 --version | |||
|
|||
ARG LLAMA_CPP_SHA=3f1ae2e32cde00c39b96be6d01c2997c29bae555 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove lines.
@@ -0,0 +1,27 @@ | |||
FROM quay.io/ramalama/ramalama:latest | |||
|
|||
ARG LLAMA_CPP_SHA=3f1ae2e32cde00c39b96be6d01c2997c29bae555 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove Lines
Add this image, we also want to see the size of this image in the build.
Co-authored-by: Steffen Roecker sroecker@redhat.com
Signed-off-by: Eric Curtin ecurtin@redhat.com