Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to v4.9.0 #21331

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Bump to v4.9.0 #21331

merged 2 commits into from
Jan 23, 2024

Conversation

ashley-cui
Copy link
Member

Bump to v4.9.0 and then v4.9.1-dev

None

@ashley-cui
Bump to v4.9.0
f7c7b0a 
Signed-off-by: Ashley Cui <acui@redhat.com>
@ashley-cui
Bump to v4.9.1-dev
d68682a 
Signed-off-by: Ashley Cui <acui@redhat.com>
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashley-cui

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2024
@mheon
Copy link
Member

mheon commented Jan 22, 2024

LGTM
/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2024
@TomSweeneyRedHat
Copy link
Member

LGTM
and yikes, we had 4.8.4-dev in the 4.9 branch. Once cut, we probably ought to rename this branch to "-rhel" or create a new one. I'd vote rename.

@mheon
Copy link
Member

mheon commented Jan 22, 2024

We can always make a RHEL branch later, if things need backporting. v4.8.4-dev was what we branched from.

@mheon
Copy link
Member

mheon commented Jan 22, 2024

We are never doing the branch-off-a-branch thing again if I have any say about it, though, this was far more painful that a normal release.

@ashley-cui
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 2f47cb9 into containers:v4.9 Jan 23, 2024
89 of 90 checks passed
@edsantiago edsantiago mentioned this pull request Mar 4, 2024
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Apr 23, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2024
@ashley-cui ashley-cui deleted the 490 branch June 17, 2024 14:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@mheon mheon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashley-cui @mheon @TomSweeneyRedHat