Add quadlet support for Rootfs and SELinux labels containers #17352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@alexlarsson PTAL |
rhatdan
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
rhatdan
force-pushed
the
rootfs
branch
2 times, most recently
from
4dcdd8d
to
fa74676
Compare
|
@ygalblum @vrothberg PTAL |
rhatdan
force-pushed
the
rootfs
branch
2 times, most recently
from
6805441
to
6b82727
Compare
|
lgtm |
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com> Add rootfs= support for quadlet containers Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Add support for disabeling SELinux process separation in the container. Add support for setting the process type of the container. Add support for setting the process MCS level of the container. Add support for setting the file type of the container. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
/lgtm |
This was referenced Feb 7, 2023
|
I know this OR is already merged, but I did have two nits:
|
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel J Walsh dwalsh@redhat.com
Does this PR introduce a user-facing change?