kube-play: add support for HostIPC in pod.Spec #17186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrothberg
reviewed
Jan 23, 2023
* play_kube_test: add tests Signed-off-by: danishprakash <danish.prakash@suse.com>
danishprakash
force-pushed
the
add-host-ipc
branch
from
acc845a
to
08186d7
Compare
vrothberg
approved these changes
Jan 26, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danishprakash, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
openshift-ci
bot
added
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
vrothberg
added a commit
to vrothberg/libpod
that referenced
this pull request
Jan 27, 2023
containers/pull/17186 and containers/pull/17201 have been merged at roughly the same time. Both work fine in isolation but the new kube test breaks in combination. Fix the IPC kube test to make CI healthy. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for hostIPC in Pod manifest for podman kube play as discussed in #17168
Signed-off-by: danishprakash danish.prakash@suse.com
Does this PR introduce a user-facing change?