Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor in latests containers/(storage, common, build, image) #17155

Merged
merged 2 commits into from
Jan 19, 2023
Merged

vendor in latests containers/(storage, common, build, image) #17155

merged 2 commits into from
Jan 19, 2023

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Jan 18, 2023 •
edited
Loading

Does this PR introduce a user-facing change?

podman build --group-add is now supported.

[NO NEW TESTS NEEDED]

@openshift-ci openshift-ci bot added release-note approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 18, 2023
@github-actions github-actions bot added the kind/api-change Change to remote API; merits scrutiny label Jan 18, 2023
@Luap99
Copy link
Member

Luap99 commented Jan 18, 2023

Bloat is at 2.5 MB, what happened in our deps?
cc @containers/podman-maintainers

@vrothberg
Copy link
Member

Bloat is at 2.5 MB, what happened in our deps? cc @containers/podman-maintainers

Sigstore...

	github.com/go-openapi/analysis v0.21.4 // indirect
	github.com/go-openapi/errors v0.20.3 // indirect
	github.com/go-openapi/jsonpointer v0.19.5 // indirect
	github.com/go-openapi/jsonreference v0.20.0 // indirect
	github.com/go-openapi/loads v0.21.2 // indirect
	github.com/go-openapi/runtime v0.24.1 // indirect
	github.com/go-openapi/spec v0.20.7 // indirect
	github.com/go-openapi/strfmt v0.21.3 // indirect
	github.com/go-openapi/swag v0.22.3 // indirect
	github.com/go-openapi/validate v0.22.0 // indirect

@rhatdan rhatdan added the bloat_approved Approve a PR in which binary file size grows by over 50k label Jan 18, 2023
@rhatdan rhatdan force-pushed the VENDOR branch 5 times, most recently from 2824bb7 to e91e391 Compare January 18, 2023 22:48
vrothberg
vrothberg approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

Restarted the flaked job

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 19, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2023
@rhatdan
vendor in latests containers/(storage, common, build, image)
f65d79f 
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@rhatdan
Add support for podman build --group-add
8f78865 
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2023

New changes are detected. LGTM label has been removed.

vrothberg
vrothberg approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@containers/podman-maintainers PTAL

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan rhatdan added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2023
@rhatdan
Copy link
Member Author

rhatdan commented Jan 19, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 19, 2023
@openshift-merge-robot openshift-merge-robot merged commit db84b2b into containers:main Jan 19, 2023
@edsantiago edsantiago mentioned this pull request Jan 25, 2023
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 14, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vrothberg vrothberg vrothberg approved these changes

Assignees

@vrothberg vrothberg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bloat_approved Approve a PR in which binary file size grows by over 50k kind/api-change Change to remote API; merits scrutiny lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rhatdan @Luap99 @vrothberg @openshift-merge-robot