Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network tests: ping redhat.com, not podman.io #17053

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Network tests: ping redhat.com, not podman.io #17053

merged 1 commit into from
Jan 10, 2023

Conversation

edsantiago
Copy link
Member

Much as we'd love to eat our dogfood, podman.io is not hosted
on reliable infrastructure; redhat.com is. Let's see if this
gets rid of CI flakes.

Closes: #17044

Signed-off-by: Ed Santiago santiago@redhat.com

None

@edsantiago
Network tests: ping redhat.com, not podman.io
37ade6b 
Much as we'd love to eat our dogfood, podman.io is not hosted
on reliable infrastructure; redhat.com is. Let's see if this
gets rid of CI flakes.

Closes: containers#17044

Signed-off-by: Ed Santiago <santiago@redhat.com>
@openshift-ci openshift-ci bot added release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 10, 2023
vrothberg
vrothberg approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [edsantiago,vrothberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Jan 10, 2023

Since neither of these failures are related to the PR, force merging
LGTM

@rhatdan rhatdan merged commit 7c95a5d into containers:main Jan 10, 2023
@edsantiago
Copy link
Member Author

Oh... well, keep in mind that merging this isn't going to fix anything. Per Paul's comment, the bug seems to be elsewhere. Sorry, I probably should've just closed this PR. Or, I see a Revert button, will that do what I hope it does?

@rhatdan
Copy link
Member

rhatdan commented Jan 10, 2023

I believe pinging redhat.com is better anyways for the statement. The issue we are dealing with now is a bad kernel.

@edsantiago edsantiago mentioned this pull request Jan 10, 2023
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 15, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vrothberg vrothberg vrothberg approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

www.podman.io flaking - netavark bug?
3 participants
@edsantiago @rhatdan @vrothberg