Updated options for QEMU on Windows hosts #17029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arixmkii the bots want you to add a test or add a no test needed message. See the failures. |
|
@n1hility PTAL |
|
LGTM once CI is green (need [NO NEW TESTS NEEDED] in description + a force push to pick it up as @baude mentions) |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arixmkii, n1hility The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Using "w" suffixed versions of QEMU binaries for correct background process handling and not bind it to lifecycle of command prompt window. Stub for arm64 version added to fix compilation issues of this target, when QEMU machine will be finally enabled. Signed-off-by: Arthur Sengileyev <arthur.sengileyev@gmail.com>
arixmkii
force-pushed
the
qemu_windows_settings
branch
from
35f28ed
to
35d2f61
Compare
|
LGTM |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are extracted from #16872 draft. arm64 will not be supported as QEMU machine host, because there is no QEMU for that arch on Windows, but it will be needed to compile remote client on that arch (alternative is to introduce a bigger refactoring around machine related code).
Using "w" suffixed versions of QEMU binaries for correct background process handling and not bind it to lifecycle of command prompt window. Stub for arm64 version added to fix compilation issues of this target, when QEMU machine will be finally enabled.
Signed-off-by: Arthur Sengileyev arthur.sengileyev@gmail.com
[NO NEW TESTS NEEDED]
Does this PR introduce a user-facing change?