Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CDI go dependency to v0.3.0 #13317

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Update CDI go dependency to v0.3.0 #13317

merged 1 commit into from
Feb 23, 2022

Conversation

elezar
Copy link
Contributor

@elezar elezar commented Feb 22, 2022

This updates the CDI dependency to the v0.3.0 tagged version instead of
relying on a pseudo version. This also addresses the fact that cgroups
are not set correctly for devices using the previous dependency.

The original work was done on #12825

Signed-off-by: Evan Lezar elezar@nvidia.com

@rhatdan
Copy link
Member

rhatdan commented Feb 22, 2022

Did you run this through
make vendor-in-container
And then commit all changes in the vendor directory?

@elezar
Copy link
Contributor Author

elezar commented Feb 22, 2022

Did you run this through make vendor-in-container And then commit all changes in the vendor directory?

No, I missed that. Have updated the PR now.

@rhatdan
Copy link
Member

rhatdan commented Feb 22, 2022

LGTM
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elezar, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2022
@TomSweeneyRedHat
Copy link
Member

@elezar Thanks for the PR! It looks like you need to rebase and repush, go.sum has merge conflicts.

@elezar
Bump CDI go dependency to v0.3.0
46b7c5b 
This updates the CDI dependency to the v0.3.0 tagged version instead of
relying on a pseudo version. This also addresses the fact that cgroups
are not set correctly for devices using the previous dependency.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar
Copy link
Contributor Author

elezar commented Feb 23, 2022

@elezar Thanks for the PR! It looks like you need to rebase and repush, go.sum has merge conflicts.

Rebased.

@elezar
Copy link
Contributor Author

elezar commented Feb 23, 2022

The failing tests are red on main too.

@mheon
Copy link
Member

mheon commented Feb 23, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2022
@openshift-merge-robot openshift-merge-robot merged commit a234e4e into containers:main Feb 23, 2022
@elezar elezar deleted the update-cdi-module branch March 9, 2022 14:49
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@mheon mheon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@elezar @rhatdan @TomSweeneyRedHat @mheon @openshift-merge-robot