-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CDI go dependency to v0.3.0 #13317
Update CDI go dependency to v0.3.0 #13317
Conversation
Did you run this through |
524bb34
to
97522ca
Compare
No, I missed that. Have updated the PR now. |
LGTM |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elezar, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@elezar Thanks for the PR! It looks like you need to rebase and repush, go.sum has merge conflicts. |
This updates the CDI dependency to the v0.3.0 tagged version instead of relying on a pseudo version. This also addresses the fact that cgroups are not set correctly for devices using the previous dependency. Signed-off-by: Evan Lezar <elezar@nvidia.com>
97522ca
to
46b7c5b
Compare
Rebased. |
The failing tests are red on |
/lgtm |
This updates the CDI dependency to the v0.3.0 tagged version instead of
relying on a pseudo version. This also addresses the fact that cgroups
are not set correctly for devices using the previous dependency.
The original work was done on #12825
Signed-off-by: Evan Lezar elezar@nvidia.com