Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate kube -s: do not print entries with value {} #11998

Closed
dilyanpalauzov opened this issue Oct 16, 2021 · 8 comments · Fixed by #12195
Closed

generate kube -s: do not print entries with value {} #11998

dilyanpalauzov opened this issue Oct 16, 2021 · 8 comments · Fixed by #12195
Assignees
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@dilyanpalauzov
Copy link
Contributor

I run a container as described at https://mail.aegee.org/cgit/aegee-ldap/tree/readme.md#n13. Then I call podman generate kube -s <ID>:

apiVersion: v1                                                      
kind: Service             
status:                       
  loadBalancer: {}
---
apiVersion: v1
kind: Pod    
spec:
  containers:
  - resources: {}
    securityContext:
      seLinuxOptions: {}
  dnsConfig: {}
status: {}

As these {} lines have no added value, they shall not be emitted.

@dilyanpalauzov dilyanpalauzov changed the title genaret kube -s: do not print entries wilth value {} generate kube -s: do not print entries wilth value {} Oct 16, 2021
@dilyanpalauzov dilyanpalauzov changed the title generate kube -s: do not print entries wilth value {} generate kube -s: do not print entries wilh value {} Oct 16, 2021
@dilyanpalauzov dilyanpalauzov changed the title generate kube -s: do not print entries wilh value {} generate kube -s: do not print entries with value {} Oct 17, 2021
@rhatdan
Copy link
Member

rhatdan commented Oct 18, 2021

#12021 Should get rid of
seLinuxOptions: {}
dnsConfig: {}

@boaz0 boaz0 closed this as completed Nov 3, 2021
@dilyanpalauzov
Copy link
Contributor Author

podman generate kube -s still prints:

apiVersion: v1                                                      
kind: Service             
status:      
  loadBalancer: {}      

apiVersion: v1              
kind: Pod 
spec:
  containers:
  - resources: {}
status: {}

@rhatdan
Copy link
Member

rhatdan commented Nov 3, 2021

Yup, not sure how we get rid of those. I believe we would need to filter those out.
@umohnani8 PTAL

@dilyanpalauzov
Copy link
Contributor Author

I wrote the last comment, because the ticket was closed.

@boaz0 boaz0 reopened this Nov 4, 2021
@boaz0
Copy link
Collaborator

boaz0 commented Nov 4, 2021

@rhatdan @dilyanpalauzov it's related to this issue in Go golang/go#22480

@rhatdan
Copy link
Member

rhatdan commented Nov 4, 2021

Sadly this has existed since 2015 or so.

@rhatdan
Copy link
Member

rhatdan commented Nov 4, 2021

@boaz0 Do you think we can filter this out in our output?

@boaz0
Copy link
Collaborator

boaz0 commented Nov 4, 2021

I think I have an idea. Mind assigning it to me?

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants