chore: default initial selection in dropdown #9537
Open
+29
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The select control automatically selects the first value if none is provided. Dropdown wasn't doing that so I added the appropriate line. Part of containers#6199. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
requested review from
jeffmaury,
cdrage and
feloy
and removed request for
a team
1 task
benoitf
approved these changes
Oct 22, 2024
benoitf
reviewed
Oct 22, 2024
Comment on lines
+44
to
+46
| if (!value && options?.length > 0) { | ||
| value = options[0].value; | ||
| } |
There was a problem hiding this comment.
wondering if it's in onMount or in effect
if you update the options it should refresh the initial value I suppose ?
There was a problem hiding this comment.
it seems that if one option is removed, it should check also if the value is still valid
so wondering if we don't need an 'initialValue' and a flag to check if the user has modified the value to either change it back to the initialValue when options are changing and if the user has not pickup anything
There was a problem hiding this comment.
(it looks like it's not reactive)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The select control automatically selects the first value if none is provided. Dropdown wasn't doing that so I added the appropriate line.
Screenshot / video of UI
N/A
What issues does this PR fix or reference?
Part of #6199. First part of #9510.
How to test this PR?
PR checks.