feat: add a way to clean logs in container's log page #9528
Conversation
benoitf
requested review from
jeffmaury,
deboer-tim and
axel7083
and removed request for
a team
fixes containers#8311 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
|
I just tried it on Fedora 40, and looks like it works to me. The 'Clear logs' button is overlapped by the scrollbar, unlike on mac, though: |
|
before implementing I tried several approach and I found out that switching back and getting the logs again was allowing people to get back the log. about the overlap of the scrollbar, I can try to move it more to the left |
There was a problem hiding this comment.
Mac scrollbars are narrower so that bit wasn't an issue for me, but I noticed some other minor UI issues as noted.
The 'reappearing logs' were also a surprise to me, and rules out uses like 'clear logs, go do X, come back to see what logs were generated'. Instead of a timestamp would 'remove top X lines' be any simpler, or is it clearing it the issue?
| } | ||
| </script> | ||
|
|
||
| <div class="absolute top-0 right-0 px-1 z-50 m-1 opacity-50 space-x-1"> |
There was a problem hiding this comment.
The first Logs I went to I wouldn't have known the button was there if I wasn't looking. Maybe a little more opacity?
Likewise, it is over top of the mem tooltip. z-order should be lowered so that tooltips remain on top.
| <div class="absolute top-0 right-0 px-1 z-50 m-1 opacity-50 space-x-1"> | ||
| <button title="Clear logs" onclick={clear}> | ||
| <Fa | ||
| class="cursor-pointer rounded-full bg-[var(--pd-button-disabled)] min-h-8 w-8 p-1.5" |
There was a problem hiding this comment.
Missing a hover effect.
The icon isn't as bright as the actions on top, but if I remove the opacity it is too bright. I think it's missing a text- and regular opacity would help with the previous comment.
What does this PR do?
add a way to clear logs in container's logs
Screenshot / video of UI
Screen.Recording.2024-10-22.at.09.15.11.mov
What issues does this PR fix or reference?
fixes #8311
How to test this PR?
start a container, go to the logs and then click on the clear button