SPEC, libcni: harmonize GC valid-attachment key #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SPEC and libcni disagreed on the name to use for still-valid attachments. Change the spec to be aligned with libcni. Signed-off-by: Casey Callendrello <c1@caseyc.net>
|
@kanpov thanks for noticing this! |
s1061123
reviewed
Jul 8, 2024
bleggett
approved these changes
Jul 8, 2024
I made an (embarassing) error where SPEC.md and libcni disagreed on the key for valid attachments for a GC operation. The spec has been updated, but libcni should set both keys as a transition mechanism. Signed-off-by: Casey Callendrello <c1@caseyc.net>
MikeZappa87
approved these changes
Jul 22, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SPEC said valid attachments should be
cni.dev/attachments, whereas libcni usedcni.dev/valid-attachments. Oops.This changes the SPEC to match libcni, and has libcni set both variables, just in case.
Fixes: #1101