Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop boost requirement #224

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Drop boost requirement #224

merged 2 commits into from
Oct 31, 2023

Conversation

sameeul
Copy link
Contributor

@sameeul sameeul commented Oct 31, 2023

  • Use C++ 17 standard
  • Replace boost::filesystem with std::filesystem
  • Replace boost::variant with std::variant
  • Remove boost::counting_iterator
  • Update GitHub Action build dependency
  • Remove boost from CMakeLists.txt

This PR is a follow-up of #223. Once this gets merged, we can update the doc and conda-recipe related files with a separate PR.

@sameeul sameeul closed this Oct 31, 2023
@sameeul sameeul reopened this Oct 31, 2023
constantinpape
constantinpape approved these changes Oct 31, 2023
View reviewed changes
Copy link
Owner

@constantinpape constantinpape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@constantinpape constantinpape merged commit c0c3259 into constantinpape:master Oct 31, 2023
15 checks passed
@constantinpape
Copy link
Owner

we can update the doc

I think we just need a minor change in the readme for this, feel free to open a PR for it.

Once this gets merged, we can update the doc and conda-recipe related files with a separate PR.

I can draft a new release soon, and then we can update the dependencies on conda-forge as well.

@sameeul sameeul deleted the drop_boost_req branch October 31, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@constantinpape constantinpape constantinpape approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sameeul @constantinpape