Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement metadata checks for downscaling #47

Merged
merged 5 commits into from
Mar 5, 2024

Conversation

martinschorb
Copy link
Contributor

type checks to fix
mobie/mobie-utils-python#135

and sanity checks to validate the written result's metadata is consistent with the input parameters.

So far supports only OME-Zarr.

Do we need these checks for N5 as well?

Copy link
Owner

@constantinpape constantinpape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !!!

@constantinpape constantinpape merged commit 108e6bc into constantinpape:master Mar 5, 2024
1 check passed
@constantinpape
Copy link
Owner

Do we need these checks for N5 as well?

I don't think so. Let's focus on ome.zarr, I hope we will be able to move away from n5 more and more...

Another question: do you think we should make a release for this? I would say this is quite important, since wrong resolution metadata will result in a lot of viewer problems.

@martinschorb
Copy link
Contributor Author

Do we need these checks for N5 as well?

I don't think so. Let's focus on ome.zarr, I hope we will be able to move away from n5 more and more...

Another question: do you think we should make a release for this? I would say this is quite important, since wrong resolution metadata will result in a lot of viewer problems.

I don't know your previous strategy and criteria for releases here, but my gut feeling would be to make one.

@constantinpape
Copy link
Owner

I went ahead with the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants