es/v2: Port /implementing-services
#215
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
srikrsna-buf
commented
Oct 8, 2024
docs/node/implementing-services.md
Outdated
|
|
||
| export const eliza: ServiceImpl<typeof ElizaService> = { | ||
| // ... | ||
| }; | ||
|
|
||
| export class Eliza implements ServiceImpl<typeof ElizaService> { | ||
| async say(req: SayRequest) { | ||
| export class Eliza implements Partial<ServiceImpl<typeof ElizaService>> { |
There was a problem hiding this comment.
I used Partial here to avoid the not implemented error, if the user decides to copy the code as is.
There was a problem hiding this comment.
This page builds on the previous page "Getting started", where we're defining the service with just this RPC. It's fine to not use Partial here.
docs/node/implementing-services.md
Outdated
|
|
||
| export default (router: ConnectRouter) => | ||
| router.service(ElizaService, { | ||
| async say(req: SayRequest, context: HandlerContext) { | ||
| return new SayResponse({ | ||
| return create(SayResponseSchema, { |
There was a problem hiding this comment.
With the added type safety of the message init types should we just recommend using the init version?
There was a problem hiding this comment.
Yes, I think we should return the init object here - we do it in pretty much every example and also in clients.
Signed-off-by: Sri Krishna Paritala <skrishna@buf.build>
srikrsna-buf
force-pushed
the
es/v2-implementing-services
branch
from
40a3a78
to
2d2571f
Compare
Signed-off-by: Sri Krishna Paritala <skrishna@buf.build>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port
/implementing-servicessection to v2.