forked from apache/druid
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate OpenCensusInputRowParser in favor of OpenCensusProtobufInputFormat #26
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
110 changes: 110 additions & 0 deletions
110
...n/java/org/apache/druid/data/input/opencensus/protobuf/OpenCensusProtobufInputFormat.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,110 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package org.apache.druid.data.input.opencensus.protobuf; | ||
|
|
||
| import com.fasterxml.jackson.annotation.JsonProperty; | ||
| import org.apache.druid.data.input.InputEntity; | ||
| import org.apache.druid.data.input.InputEntityReader; | ||
| import org.apache.druid.data.input.InputFormat; | ||
| import org.apache.druid.data.input.InputRowSchema; | ||
| import org.apache.druid.data.input.impl.ByteEntity; | ||
| import org.apache.druid.java.util.common.StringUtils; | ||
|
|
||
| import java.io.File; | ||
| import java.util.Objects; | ||
|
|
||
| public class OpenCensusProtobufInputFormat implements InputFormat | ||
| { | ||
| private static final String DEFAULT_METRIC_DIMENSION = "name"; | ||
| private static final String DEFAULT_RESOURCE_PREFIX = "resource."; | ||
|
|
||
| private final String metricDimension; | ||
| private final String metricLabelPrefix; | ||
| private final String resourceLabelPrefix; | ||
|
|
||
| public OpenCensusProtobufInputFormat( | ||
| @JsonProperty("metricDimension") String metricDimension, | ||
| @JsonProperty("metricLabelPrefix") String metricLabelPrefix, | ||
| @JsonProperty("resourceLabelPrefix") String resourceLabelPrefix | ||
| ) | ||
| { | ||
| this.metricDimension = metricDimension != null ? metricDimension : DEFAULT_METRIC_DIMENSION; | ||
| this.metricLabelPrefix = StringUtils.nullToEmptyNonDruidDataString(metricLabelPrefix); | ||
| this.resourceLabelPrefix = resourceLabelPrefix != null ? resourceLabelPrefix : DEFAULT_RESOURCE_PREFIX; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean isSplittable() | ||
| { | ||
| return false; | ||
| } | ||
|
|
||
| @Override | ||
| public InputEntityReader createReader(InputRowSchema inputRowSchema, InputEntity source, File temporaryDirectory) | ||
| { | ||
| return new OpenCensusProtobufReader( | ||
| inputRowSchema.getDimensionsSpec(), | ||
| (ByteEntity) source, | ||
| metricDimension, | ||
| metricLabelPrefix, | ||
| resourceLabelPrefix | ||
| ); | ||
| } | ||
|
|
||
| @JsonProperty | ||
| public String getMetricDimension() | ||
| { | ||
| return metricDimension; | ||
| } | ||
|
|
||
| @JsonProperty | ||
| public String getMetricLabelPrefix() | ||
| { | ||
| return metricLabelPrefix; | ||
| } | ||
|
|
||
| @JsonProperty | ||
| public String getResourceLabelPrefix() | ||
| { | ||
| return resourceLabelPrefix; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object o) | ||
| { | ||
| if (this == o) { | ||
| return true; | ||
| } | ||
| if (!(o instanceof OpenCensusProtobufInputFormat)) { | ||
| return false; | ||
| } | ||
| OpenCensusProtobufInputFormat that = (OpenCensusProtobufInputFormat) o; | ||
| return Objects.equals(metricDimension, that.metricDimension) && Objects.equals( | ||
| metricLabelPrefix, | ||
| that.metricLabelPrefix | ||
| ) && Objects.equals(resourceLabelPrefix, that.resourceLabelPrefix); | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() | ||
| { | ||
| return Objects.hash(metricDimension, metricLabelPrefix, resourceLabelPrefix); | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this auto-formatted by spotless 😛?
IMO this would be a bit easier on the eyes:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's all auto-generated by IntelliJ using Druid's codestyle 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed