Read build metadata when testing package build #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_build_metadata reads a custom version file which is necessary for finding and installing a package when testing a package build.
llawall
changed the title
|
Any thoughts on this? Are you happy to merge the code here or would you like it changed or refactored in some way? |
msarahan
added a commit
that referenced
this pull request
Jan 26, 2016
Read build metadata when testing package build
|
Thanks for ironing out that inconsistency. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_build_metadata reads a custom version file which is necessary
for finding and installing a package when testing a package build.
#676