You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am including a cookiecutter template for creating well-formed python projects with an (internal) utility package. This template includes all I need for good version control, i.e. a pre-filled .gitignore and .gitattributes file.
Building the package with python setup.py sdist works nicely.
Building the package with python setup.py bdist works as well, except for an unrelated issue with compiled template files, which I since circumvented.
Actual Behavior
Building the package with python setup.py bdist_conda nearly works, but my shipped template is missing the .gitignore, but not the .gitattributes files!
Expected Behavior
Building the package with python setup.py bdist_conda works, and my package contains all the files I want it to.
I am pretty sure I have tracked down the culprit commit to this (cf. #1585) where a filter was adapted to filter out some files from the list of files to be copied. I can understand that you filter out the .git directory (at least I have not yet had a usecase for that), but please don't filter out .gitignore. I also think that .gitmodules should stay.
Indeed, the relevant test only tests for the removal of the .gitdirectory.
Note: The files have explicitly been included by a MANIFEST.in with a recursive-include mypgk/project_template * entry. If you want to generally remove all .gitignore files, maybe this can be used to ensure that explicitly whitelisted files still make it into the package.
Steps to Reproduce
Create a python package
Include a .gitignore file because you want to ship a nice git repo template
Observe that the .gitignore file is gone in the final package in conda-bld
I am including a cookiecutter template for creating well-formed python projects with an (internal) utility package. This template includes all I need for good version control, i.e. a pre-filled
.gitignore
and.gitattributes
file.Building the package with
python setup.py sdist
works nicely.Building the package with
python setup.py bdist
works as well, except for an unrelated issue with compiled template files, which I since circumvented.Actual Behavior
Building the package with
python setup.py bdist_conda
nearly works, but my shipped template is missing the.gitignore
, but not the.gitattributes
files!Expected Behavior
Building the package with
python setup.py bdist_conda
works, and my package contains all the files I want it to.I am pretty sure I have tracked down the culprit commit to this (cf. #1585) where a filter was adapted to filter out some files from the list of files to be copied. I can understand that you filter out the
.git
directory (at least I have not yet had a usecase for that), but please don't filter out.gitignore
. I also think that.gitmodules
should stay.Indeed, the relevant test only tests for the removal of the
.git
directory.Note: The files have explicitly been included by a MANIFEST.in with a
recursive-include mypgk/project_template *
entry. If you want to generally remove all.gitignore
files, maybe this can be used to ensure that explicitly whitelisted files still make it into the package.Steps to Reproduce
.gitignore
file because you want to ship a nice git repo template.gitignore
file is gone in the final package in conda-bldOutput of conda info
The text was updated successfully, but these errors were encountered: