Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Attempting to test against conda-build master and the latest released version of conda-build #15

Closed
wants to merge 2 commits into from

Conversation

ericdill
Copy link
Contributor

I could have done this by turning on travis for my fork, but this is easier.
I'm also doing this because I think I already found an API change in conda-build
master that breaks resolved_distribution.py. Let's see if the test suite on conda-build-all hits it.
If not, I'll make a test to expose it

Useful to test against master branch of conda-build to detect
regressions and API changes before they land in the latest tagged
release
@pelson
Copy link
Contributor

pelson commented Jan 26, 2016

Thanks @ericdill - interested to see what has changed with conda-build. Definitely don't want you to drop this investigation.

@ericdill
Copy link
Contributor Author

@pelson At the end of this circle-ci build is what I think the problem is. I dug a little into the source for conda-build-all and this self.meta.parse_again() call gained a positional argument in conda-build master. https://github.com/conda/conda-build/blob/33135a88a103c566536a7fc40868df73d2795213/conda_build/metadata.py#L330

@pelson
Copy link
Contributor

pelson commented Jan 27, 2016

Thanks @ericdill. conda/conda-build#742

@ericdill
Copy link
Contributor Author

ericdill commented Feb 1, 2016

Oh, great. Glad you found the problem and already fixed it! Does it still make sense to try to test against current master of conda-build?

@pelson
Copy link
Contributor

pelson commented Feb 1, 2016

Does it still make sense to try to test against current master of conda-build?

That's a hard call. In some ways yes, in otherways, we don't test all master versions of dependencies (e.g. python, conda, etc.).

@ericdill
Copy link
Contributor Author

ericdill commented Feb 1, 2016

Yeah, I suppose its better to just fix upstream libraries when bugs are discovered. No reason to make the automated testing more opaque than it needs to be.

@ericdill ericdill closed this Feb 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants