Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add formulas (and schedula) #8269

Merged
merged 4 commits into from
May 20, 2019
Merged

Add formulas (and schedula) #8269

merged 4 commits into from
May 20, 2019

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented May 5, 2019

Checklist

  • License file is packaged (see here for an example)
  • Source is from official source
    • the pypi source doesn't contain enough stuff, due to install-time use of sphinx, etc.

  • Package does not vendor other packages
  • Build number is 0
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

Adds formulas and its primary dependency schedula.

These both have a large number of optional dependencies... i'm tempted to add openpyxl to formulas, but i suppose there is a reason you'd want to do something with excel AST that wasn't coming from an actual excel file...

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/formulas, recipes/schedula) and found some lint.

Here's what I've got...

For recipes/formulas:

  • The build section contained an unexpected subsection name. patches is not a valid subsection name.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/formulas, recipes/schedula) and found it was in an excellent condition.

@bollwyvl
Copy link
Contributor Author

bollwyvl commented May 5, 2019

Windows builds hitting conda-forge/python-graphviz-feedstock#25 ?

@ankostis
Copy link

ankostis commented May 17, 2019

@bollwyvl i'm thinking 2 improvements on this recipe:

Although both formulas & schedula are PY>=3.5 only, you can still apply the noarch: python trick described in conda/conda#5971 and exemplified in https://github.com/conda-forge/pyscaffold-feedstock/blob/02b91712d911c593f0b9933fcd27a37aa7b0d9d2/recipe/meta.yaml.

Another point is that conda-build-4.4.0+ can express version-boundaries for pip's optional-extras with conda-build's undocumented(conda/conda-docs#580) run_constrained feature(conda/conda#4982).

Do you want me to provide a PR for these 2 packages?

@bollwyvl
Copy link
Contributor Author

bollwyvl commented May 17, 2019

@ankostis Do you want me to provide a PR for these 2 packages?

sure, fire away!

I had had some issues as late as a few months ago with specifying python verions in noarch: python packages, good to know that has been cleared up.

It's not so much a run_constrained thing, as they aren't exotic, it's more, I don't know whether to force the optional dependencies, because I don't know how useful it is without them. But constraining them would be fine.

@bollwyvl
Copy link
Contributor Author

@ankostis ha, wait, they already are noarch: python. I don't think the other deps are really worthwhile even bothering with pinning, etc. We could consider adding meta-packages, e.g. schedula-web but that shouldn't block review. Which reminds me:

@conda-forge/help-python please take a 👁️ 👃 👁️ !

@chrisburr
Copy link
Member

Ouch that's a lot of host dependencies...

Looks good, LGTM 👍

@chrisburr chrisburr merged commit 29c7303 into conda-forge:master May 20, 2019
@bollwyvl
Copy link
Contributor Author

bollwyvl commented May 20, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants