-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add formulas (and schedula) #8269
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/formulas:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Windows builds hitting conda-forge/python-graphviz-feedstock#25 ? |
@bollwyvl i'm thinking 2 improvements on this recipe: Although both Another point is that Do you want me to provide a PR for these 2 packages? |
sure, fire away! I had had some issues as late as a few months ago with specifying python verions in It's not so much a |
@ankostis ha, wait, they already are @conda-forge/help-python please take a 👁️ 👃 👁️ ! |
Ouch that's a lot of host dependencies... Looks good, LGTM 👍 |
I know, right? Thanks for the merge!
…On Mon, May 20, 2019, 16:41 Chris Burr ***@***.***> wrote:
Merged #8269 <#8269>
into master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8269?email_source=notifications&email_token=AAALCREIMUWF44QEZFI3MJLPWMEJDA5CNFSM4HK2E54KYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGORRJRXVQ#event-2354256854>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAALCRCIBVKDNTBYK5ULIRDPWMEJDANCNFSM4HK2E54A>
.
|
Checklist
Adds formulas and its primary dependency schedula.
These both have a large number of optional dependencies... i'm tempted to add
openpyxl
to formulas, but i suppose there is a reason you'd want to do something with excel AST that wasn't coming from an actual excel file...