Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jpeg recipe with custom CMake file. #369

Merged
merged 1 commit into from
Apr 15, 2016

Conversation

jakirkham
Copy link
Member

Closes #355

Simply takes ( #355 ) and squashes it into one commit. Also added executable permissions to the build scripts (bld.bat and build.sh), which doesn't really matter, but is nice.

cc @gillins @patricksnape @msarahan @ocefpaf

@jakirkham jakirkham mentioned this pull request Apr 15, 2016
@jakirkham
Copy link
Member Author

jakirkham commented Apr 15, 2016

Once CI passes, would you like to do the honors, @ocefpaf?

@ocefpaf ocefpaf merged commit c853d26 into conda-forge:master Apr 15, 2016
@ocefpaf
Copy link
Member

ocefpaf commented Apr 15, 2016

Thanks @jakirkham!

@jakirkham
Copy link
Member Author

jakirkham commented Apr 15, 2016

Thanks for keeping an eye on this and getting it in, @ocefpaf. We should rebuild hdf4 once this is released to see how it goes.

@jakirkham jakirkham deleted the add_jpeg branch April 15, 2016 18:43
@ocefpaf
Copy link
Member

ocefpaf commented Apr 15, 2016

We should rebuild hdf4 once this is released to see how it goes.

I am on it.

@dopplershift
Copy link
Member

dopplershift commented Apr 15, 2016

Rebuild jasper as well, since it's linked against jpeg8 (conda-forge/jasper-feedstock#2). Otherwise, installing conda-forge's jasper package out of the box is broken now.

@ocefpaf
Copy link
Member

ocefpaf commented Apr 15, 2016

See conda-forge/jasper-feedstock#3

@dopplershift
Copy link
Member

I wish there were some way not to pin the package to a particular version of jpeg, but to note that it needs the version it built against.

@msarahan
Copy link
Member

@dopplershift I think that's similar to the ideas in conda/conda-build#848 and other related PRs - you should weigh in there with your request and any ideas for implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants