Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: python>=3.9; rasterio>=1.2 #70

Merged
merged 1 commit into from
Mar 22, 2023
Merged

DEP: python>=3.9; rasterio>=1.2 #70

merged 1 commit into from
Mar 22, 2023

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Mar 21, 2023

Xref https://github.com/corteva/rioxarray/blame/0.14.0/setup.cfg. Fixes issue when running rioxarray=0.14.0 with Python 3.8:

    import rioxarray
../../../micromamba-root/envs/project/lib/python3.8/site-packages/rioxarray/__init__.py:5: in <module>
    import rioxarray.raster_array  # noqa
../../../micromamba-root/envs/project/lib/python3.8/site-packages/rioxarray/raster_array.py:37: in <module>
    from rioxarray.raster_writer import (
../../../micromamba-root/envs/project/lib/python3.8/site-packages/rioxarray/raster_writer.py:18: in <module>
    from rioxarray._io import _get_unsigned_dtype
../../../micromamba-root/envs/project/lib/python3.8/site-packages/rioxarray/_io.py:38: in <module>
    from rioxarray.rioxarray import _generate_spatial_coords
../../../micromamba-root/envs/project/lib/python3.8/site-packages/rioxarray/rioxarray.py:53: in <module>
    def _resolution(affine: Affine) -> tuple[float, float]:
E   TypeError: 'type' object is not subscriptable

Patches #69

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

- python >=3.8
- rasterio >=1.1.1
- python >=3.9
- rasterio >=1.2
- scipy
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snowman2, did you want to keep scipy as a dependency here, or remove it since it has been made optional since corteva/rioxarray#416?

Suggested change
- scipy

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can leave it for now. Do you need it to be optional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really. Was just looking at the list and saw it was missing in the required dependencies.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thanks for bringing it up.

@weiji14
Copy link
Member Author

weiji14 commented Mar 21, 2023

@conda-forge-admin, please rerender

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/rioxarray-feedstock/actions/runs/4484797202.

@weiji14 weiji14 marked this pull request as ready for review March 21, 2023 23:44
@weiji14 weiji14 requested a review from snowman2 as a code owner March 21, 2023 23:44
@snowman2 snowman2 merged commit e2d9460 into conda-forge:main Mar 22, 2023
@snowman2
Copy link
Member

Thanks @weiji14 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants