Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 6.0.0 #17

Merged
merged 10 commits into from
Oct 10, 2021
Merged

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Oct 8, 2021

This was done manually due to conda-forge/libignition-gazebo-feedstock#24 .

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@traversaro
Copy link
Contributor Author

A rapid check by adding verbosity to the tests reveals that, as it was the case in conda-forge/libignition-rendering4-feedstock#19 (comment), that the tests that are passing on Windows and Linux are not actually passing, for example on Linux INTEGRATION_camera is:

test 16
      Start 16: INTEGRATION_camera

16: Test command: $SRC_DIR/build/bin/INTEGRATION_camera "--gtest_output=xml:$SRC_DIR/build/test_results/INTEGRATION_camera.xml"
16: Test timeout computed to be: 240
16: [==========] Running 1 test from 1 test case.
16: [----------] Global test environment set-up.
16: [----------] 1 test from CameraSensor/CameraSensorTest
16: [ RUN      ] CameraSensor/CameraSensorTest.ImagesWithBuiltinSDF/ogre
16: [Msg] Loading plugin [ignition-rendering-ogre]
16: Error while loading the library [$PREFIX/lib/ign-rendering-6/engine-plugins/libignition-rendering-ogre.so]: libGL.so.1: cannot open shared object file: No such file or directory
16: [Err] [RenderEngineManager.cc:470] Failed to load plugin [ignition-rendering-ogre] : couldn't load library on path [$PREFIX/lib/ign-rendering-6/engine-plugins/libignition-rendering-ogre.so].
16: [Dbg] [camera.cc:84] Engine 'ogre' is not supported
16: [       OK ] CameraSensor/CameraSensorTest.ImagesWithBuiltinSDF/ogre (67 ms)
16: [----------] 1 test from CameraSensor/CameraSensorTest (68 ms total)
16: 
16: [----------] Global test environment tear-down
16: [==========] 1 test from 1 test case ran. (68 ms total)
16: [  PASSED  ] 1 test.
16/39 Test #16: INTEGRATION_camera ......................   Passed    0.20 sec

while on Windows:

test 15
      Start 15: INTEGRATION_camera

15: Test command: %SRC_DIR%\build\bin\INTEGRATION_camera.exe "--gtest_output=xml:D:/bld/libignition-sensors6_1633707889581/work/build/test_results/INTEGRATION_camera.xml"
15: Test timeout computed to be: 240
15: [==========] Running 1 test from 1 test case.
15: [----------] Global test environment set-up.
15: [----------] 1 test from CameraSensor/CameraSensorTest
15: [ RUN      ] CameraSensor/CameraSensorTest.ImagesWithBuiltinSDF/ogre
15: [Msg] Loading plugin [ignition-rendering-ogre]
15: [Err] [D:\bld\libignition-rendering6_1633681302936\work\src\RenderEngineManager.cc:461] Failed to load plugin [ignition-rendering-ogre] : couldn't find shared library.
15: [Dbg] [%SRC_DIR%\test\integration\camera.cc:84] Engine 'ogre' is not supported
15: [       OK ] CameraSensor/CameraSensorTest.ImagesWithBuiltinSDF/ogre (80 ms)
15: [----------] 1 test from CameraSensor/CameraSensorTest (80 ms total)
15: 
15: [----------] Global test environment tear-down
15: [==========] 1 test from 1 test case ran. (80 ms total)
15: [  PASSED  ] 1 test.
15/38 Test #15: INTEGRATION_camera ......................   Passed    0.13 sec

Again, as in conda-forge/libignition-rendering4-feedstock#19 (comment) it probably just make sense to try to run the test locally and then merge.

@Tobias-Fischer Tobias-Fischer mentioned this pull request Oct 8, 2021
3 tasks
@traversaro
Copy link
Contributor Author

Just tested on a real macOS machine, indeed the offending tests fail:

15/38 Test #15: INTEGRATION_camera ......................***Exception: SegFault  0.10 sec
      Start 16: check_INTEGRATION_camera
16/38 Test #16: check_INTEGRATION_camera ................   Passed    0.03 sec
      Start 17: INTEGRATION_depth_camera
17/38 Test #17: INTEGRATION_depth_camera ................***Exception: SegFault  0.10 sec
      Start 18: check_INTEGRATION_depth_camera
18/38 Test #18: check_INTEGRATION_depth_camera ..........   Passed    0.03 sec
      Start 19: INTEGRATION_gpu_lidar_sensor
19/38 Test #19: INTEGRATION_gpu_lidar_sensor ............***Exception: SegFault  0.06 sec
      Start 20: check_INTEGRATION_gpu_lidar_sensor
20/38 Test #20: check_INTEGRATION_gpu_lidar_sensor ......   Passed    0.03 sec
      Start 21: INTEGRATION_rgbd_camera
21/38 Test #21: INTEGRATION_rgbd_camera .................***Exception: SegFault  0.10 sec
      Start 22: check_INTEGRATION_rgbd_camera
22/38 Test #22: check_INTEGRATION_rgbd_camera ...........   Passed    0.03 sec
      Start 23: INTEGRATION_thermal_camera
23/38 Test #23: INTEGRATION_thermal_camera ..............***Exception: SegFault  0.10 sec
      Start 24: check_INTEGRATION_thermal_camera
24/38 Test #24: check_INTEGRATION_thermal_camera ........   Passed    0.03 sec

Detailed error:

est 15
    Start 15: INTEGRATION_camera

15: Test command: /Users/traversaro/src/ign-sensors/build/bin/INTEGRATION_camera "--gtest_output=xml:/Users/traversaro/src/ign-sensors/build/test_results/INTEGRATION_camera.xml"
15: Test timeout computed to be: 240
15: [==========] Running 1 test from 1 test case.
15: [----------] Global test environment set-up.
15: [----------] 1 test from CameraSensor/CameraSensorTest
15: [ RUN      ] CameraSensor/CameraSensorTest.ImagesWithBuiltinSDF/ogre
15: [Err] [OgreRenderEngine.cc:462] Unable to load Ogre Plugin[/Users/traversaro/mambaforge/envs/ignsensors/lib/OGRE]. Rendering will not be possible.Make sure you have installed OGRE properly.
15: [Err] [OgreRenderEngine.cc:505] unable to find OpenGL rendering system. OGRE is probably installed incorrectly. Double check the OGRE cmake output, and make sure OpenGL is enabled.
1/2 Test #15: INTEGRATION_camera ...............***Exception: SegFault  0.09 sec
test 16
    Start 16: check_INTEGRATION_camera

@traversaro
Copy link
Contributor Author

All test pass successfully if I set the following env variables:

export OGRE_RESOURCE_PATH=$CONDA_PREFIX/lib/OGRE/
export IGN_RENDERING_RESOURCE_PATH=$CONDA_PREFIX/share/ignition/ignition-rendering6

So probably there is an issue similar to conda-forge/libignition-rendering4-feedstock#25 (comment), just on macOS .

@traversaro
Copy link
Contributor Author

traversaro commented Oct 9, 2021

All test pass successfully if I set the following env variables:

export OGRE_RESOURCE_PATH=$CONDA_PREFIX/lib/OGRE/
export IGN_RENDERING_RESOURCE_PATH=$CONDA_PREFIX/share/ignition/ignition-rendering6

So probably there is an issue similar to conda-forge/libignition-rendering4-feedstock#25 (comment), just on macOS .

Note that even after setting those env variables, the test pass but an error is printed:

test 15
    Start 15: INTEGRATION_camera

15: Test command: /Users/traversaro/src/ign-sensors/build/bin/INTEGRATION_camera "--gtest_output=xml:/Users/traversaro/src/ign-sensors/build/test_results/INTEGRATION_camera.xml"
15: Test timeout computed to be: 240
15: [==========] Running 1 test from 1 test case.
15: [----------] Global test environment set-up.
15: [----------] 1 test from CameraSensor/CameraSensorTest
15: [ RUN      ] CameraSensor/CameraSensorTest.ImagesWithBuiltinSDF/ogre
15: [Err] [OgreRenderEngine.cc:462] Unable to load Ogre Plugin[/Users/traversaro/mambaforge/envs/ignsensors/lib/OGRE]. Rendering will not be possible.Make sure you have installed OGRE properly.
15: [Msg] Loading plugin [ignition-rendering-ogre]
15: [Dbg] [CameraSensor.cc:271] Camera images for [camera1] advertised on [/test/integration/CameraPlugin_imagesWithBuiltinSDF]
15: [Dbg] [CameraSensor.cc:524] Camera info for [camera1] advertised on [/test/integration/camera_info]
15: [Dbg] [CameraSensor.cc:357] Enabling camera sensor: 'camera1' data generation.
15: [       OK ] CameraSensor/CameraSensorTest.ImagesWithBuiltinSDF/ogre (242 ms)
15: [----------] 1 test from CameraSensor/CameraSensorTest (242 ms total)
15: 
15: [----------] Global test environment tear-down
15: [==========] 1 test from 1 test case ran. (242 ms total)
15: [  PASSED  ] 1 test.
1/2 Test #15: INTEGRATION_camera ...............   Passed    0.27 sec

However, I have the impression that that error is just a spurious error. Indeed, I tried to run the examples/save_image example, and even there the error is printed, but then the image is saved, proving that the rendering happened even if the error is printed:

(ignsensors) Silvios-iMac:build traversaro$ ./save_image 
[Err] [OgreRenderEngine.cc:462] Unable to load Ogre Plugin[/Users/traversaro/mambaforge/envs/ignsensors/lib/OGRE]. Rendering will not be possible.Make sure you have installed OGRE properly.
Saving image.png

image

@traversaro
Copy link
Contributor Author

Hopefully conda-forge/libignition-rendering4-feedstock#27 should solve all the problem with the tests, and once that is merge we can merge this PR as well.

@traversaro traversaro closed this Oct 9, 2021
@traversaro traversaro reopened this Oct 9, 2021
@traversaro
Copy link
Contributor Author

Just tested with libignition-rendering6: 6.0.1-hdd72079_1 (i.e. the build after conda-forge/libignition-rendering4-feedstock#27). As in the case of ign-rendering, now tests that involve rendering are failing for both macOS and Windows, but that is due to the Azure headless environment as I tested manually on normal systems and the tests are passing fine.

@Tobias-Fischer
Copy link
Contributor

Great, shall we merge this in?

@traversaro
Copy link
Contributor Author

Great, shall we merge this in?

Sure!

@traversaro traversaro merged commit d25517e into conda-forge:master Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants