Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v7 to abi_migration_branches #59

Merged
merged 2 commits into from
Oct 2, 2021

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Oct 2, 2021

As discussed in #58 (comment) . As Ignition Edifice use Ignition Msgs 7 (see https://ignitionrobotics.org/docs/edifice) and it is supposed to be supported upstream until March 2022 (see https://ignitionrobotics.org/docs/all/releases) I think it is relatively low effort to keep it around. If it turns out that it is too much work to get that PR merged, we can remove the branch.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@traversaro traversaro merged commit 201c462 into conda-forge:master Oct 2, 2021
@traversaro traversaro deleted the add_v7_abi_migration branch October 2, 2021 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants