Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put on napari hub #530

Open
constantinpape opened this issue Apr 22, 2024 · 6 comments · Fixed by #606
Open

Put on napari hub #530

constantinpape opened this issue Apr 22, 2024 · 6 comments · Fixed by #606

Comments

@constantinpape
Copy link
Contributor

https://www.napari-hub.org/

@GenevieveBuckley
Copy link
Collaborator

Discussed previously here: https://forum.image.sc/t/publish-napari-plugin-with-conda-dependencies/65653

Summarizing:

  • We need to release micro-sam on PyPI. Then napari-hub will automatically scrape PyPI and will find micro-sam, because we already have the Framework :: napari classifier.
  • Because micro-sam requires some dependencies only available on conda (not pypi), we will...
    • Not worry about the fact it will not install everything correctly if users try pip install micro-sam (this is not great, but there is no good alternative if we want micro-sam discoverable on the napari-hub)
    • Add a line to the documentation (maybe around here) to tell users please do not use pip to install micro-sam. Hopefully anyone with installation problems will see this page and then try again with conda or from source.

@constantinpape
Copy link
Contributor Author

Thanks for looking into this @GenevieveBuckley. Let's go ahead and put a "dummy" micro_sam package on pip then so that it can be installed via napari.

Would you have time to look into this? (There's no hurry!)

@GenevieveBuckley
Copy link
Collaborator

Thanks for looking into this @GenevieveBuckley. Let's go ahead and put a "dummy" micro_sam package on pip then so that it can be installed via napari.

Would you have time to look into this? (There's no hurry!)

I've made a PR here: #606

@constantinpape
Copy link
Contributor Author

I have made a new release now, but the deploy part of the action that would push the package to PyPI was skipped, see https://github.com/computational-cell-analytics/micro-sam/actions/runs/9222705341.

I can't see why in the log; any idea why this may happen @GenevieveBuckley?

@GenevieveBuckley
Copy link
Collaborator

I have made a new release now, but the deploy part of the action that would push the package to PyPI was skipped, see https://github.com/computational-cell-analytics/micro-sam/actions/runs/9222705341.

I can't see why in the log; any idea why this may happen @GenevieveBuckley?

There are two conditions for the deploy job:

  1. The previous update_release_draft job in the release_drafter workflow completed successfully, and
  2. If there is a tag if: contains(github.ref, 'tags')

I was assuming that the deploy job would see that the first job created a new tag, but perhaps this is not how things work. Maybe because that tag is being created from inside the update_release_draft job?

@GenevieveBuckley
Copy link
Collaborator

I guess the main question is: how does the current release drafter work?
Should the deploy job be turned into a step that runs after the others (possibly conditional on the results from a previous step?)
Is there ever a case where a release could be drafted, but we don't want anything uploaded to pypi?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants