Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add micro-sam version signature to files #445

Closed
anwai98 opened this issue Mar 15, 2024 · 2 comments
Closed

Add micro-sam version signature to files #445

anwai98 opened this issue Mar 15, 2024 · 2 comments

Comments

@anwai98
Copy link
Contributor

anwai98 commented Mar 15, 2024

It would be nice to add signatures / headers of micro-sam's version (goes in the direction of consistency and reproducability) in the embedding files, and to the continuous committing of objects volume (maybe adding the model link signature here as well, the same how it goes for the embedding files?): #434 (comment)

@constantinpape
Copy link
Contributor

This is a good idea, and we should write the micro_sam version as well as more information about the model, e.g. the weight hash both to the embedding and the commit file (see #408).

This is pending #426 , which is updating the logic behind the embedding computation.

@constantinpape
Copy link
Contributor

Implemented in #507 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants