-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect results with MPS #435
Comments
@constantinpape My Mac has the M3 chip or more specifically it's M3 Max. I also just checked that on my private Macbook with the M1 chip. There I get the same errors. |
Thanks for checking. And this inconsistency with our tests in the CLI is weird... |
I don't see a test error when I run I'm using:
Details of pytest output (click to expand)
Details `conda list` (click to expand)
|
Re-reading, it seems you want to know what happens for those specific versions of pytorch and torchvision. Here are those results, but I still don't see any errors and it doesn't seem any different than before.
Details of pytest output
Details of conda environment
|
We should double check this again. I am confused that this happens with an M1 chipset for your private laptop @Marei33. |
We investigated this a bit further, and the only remaining test error on both of @Marei33 is this one: ![]() This is not so critical, because the corresponding prompt is not really used in the annotator tools. It's also gotten a bit more difficult to debug this due to #558. (So I will unlink this from the milestone.) For reference, here are the two environments where the error occurs for @Marei33 : Environment on M1(click to expand)
packages in environment at /Users/marei/mambaforge/envs/sam:Name Version Build Channelabsl-py 2.1.0 pyhd8ed1ab_0 conda-forge Environment on M3(click to expand)
packages in environment at /Users/marei/mambaforge/envs/sam:Name Version Build Channelabsl-py 2.1.0 pyhd8ed1ab_0 conda-forge Both use pytorch 2.1.2; my current guess is that this is causing this, I will recheck here once the MAC CI is running again. |
@Marei33 observed incorrect results when using MPS results (including failing tests) when using the MPS backend.
This happened with two torch / torchvision settings:
pytorch = 2.0.1; torchvision: 0.15.2
pytorch=2.2.1 und torchvision=0.17.1
For some reason this is not picked up by our tests that run on
MAC-Latest
@Marei33: what chipset does your Mac have? M1, M2 or M3?
@GenevieveBuckley: could you check if this still works on your MAC (you can just run
test/test_prompt_based_segmentation.py
).The text was updated successfully, but these errors were encountered: