[CM-8224] replace comet api client usage in log user feedback #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et_api_client_usage_in_log_user_feedback
…o CM-8224_replace_comet_api_client_usage_in_log_user_feedback
alexkuzmik
requested changes
Oct 10, 2023
src/comet_llm/experiment_info.py
Outdated
| @@ -22,7 +22,7 @@ | |||
|
|
|||
| @dataclasses.dataclass | |||
| class ExperimentInfo: | |||
| api_key: Optional[str] | |||
| api_key: str | |||
There was a problem hiding this comment.
Keep it Optional, I needed that while working on openai integration.
src/comet_llm/api.py
Outdated
| api_key_not_found_message=logging_messages.API_KEY_NOT_FOUND_MESSAGE | ||
| % "log_user_feedback", | ||
| ) | ||
| experiment_api = ExperimentAPI.from_existing_id(id, info.api_key) |
alexkuzmik
approved these changes
Oct 11, 2023
|
Will be merged after the issue with metrics is fixed on the backend. |
jynx10
deleted the
CM-8224_replace_comet_api_client_usage_in_log_user_feedback
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.